Add OpenVox support #935

bastelfreak · 2025-03-11T09:51:09Z

This adds a fact that discovers if the Perforce or OpenVox agent is installed. If none are installed yet, we default to the Perforce package for backwards compatibility.

bastelfreak · 2025-03-11T09:51:23Z

This is a resubmission of #933. I pasically added pick() to handle situations where the fact is undef.

lib/facter/puppet_flavor.rb

manifests/params.pp

charlesc-profusion · 2025-03-11T17:28:24Z

This doesn't work on Openvox 7:

binford2k · 2025-03-11T18:50:51Z

ah yeah, we didn't backport that to 7.x. We probably should. Lemme chat with the team.

Stricken1670 · 2025-03-14T12:19:11Z

EDIT: found it!

So I just installed this module and it's active, and I applied the https://github.com/theforeman/puppet-puppet/pull/935.diff for this PR and now I can install openvox with:

  if $facts['networking']['hostname'] == 'labrat' {
    class {
      'puppet':
        runmode => 'cron',
        client_package => 'openvox-agent',
        agent_server_hostname => 'theforeman.example.com',
    }
  }

Although it doesn't set up the repo yet.

markeganfuller · 2025-03-14T15:07:12Z

I think it's also required that terminus_package is set to openvoxdb-termini on puppetdb::master::config in puppet::server::puppetdb.

ekohl

Can we make it reflect that OpenVox introduced an implementation fact?

manifests/server/puppetdb.pp

sbernhard · 2025-09-09T15:52:19Z

@bastelfreak Any plans to continue this? (looks like there are conflicts as #936 was already merged)

sbernhard · 2025-10-02T16:16:36Z

@bastelfreak The failling tests are not related to this change. Am I right? What do we need to merge this then? How can we help?

bastelfreak · 2025-10-02T20:57:18Z

@sbernhard

as a first step, Drop puppet 7 support #955 should be merged to remove the broken puppet 7 integration (and before that maybe do a minor release).
I pulled some cleanups into Cleanup leftovers for Debian without systemd #964
and fixed docs in puppet::server::puppetdb & puppet::server::puppetserver: Fix puppet-strings documentation #965

bastelfreak · 2025-10-10T08:52:15Z

manifests/server/puppetserver.pp

  # We need a method to determine what version is installed.
  $real_puppetserver_version = pick($puppetserver_version, '8.0.0')

-  $puppetserver_package = pick($puppet::server::package, 'puppetserver')


It seems like the variable isn't used anywhere

spec/acceptance/puppetserver_upgrade_spec.rb

evgeni · 2025-10-10T10:53:20Z

manifests/params.pp

-  if ($facts['os']['family'] =~ /(FreeBSD|DragonFly)/) {
-    $server_package = "puppetserver${puppet_major}"
+  # Add support for OpenVox. Default to puppet if nothing is installed yet
+  $puppet_flavor       = pick($facts['implementation'], 'puppet')


wonder if these vars should use implementation instead of flavor given that the fact is also implementation

not going to block on this

This adds a fact that discovers if the Perforce or OpenVox agent is installed. If none are installed yet, we default to the Perforce package for backwards compatibility.

evgeni · 2025-10-10T11:30:22Z

@ekohl as you had requested changes, I'll leave the final merge to you

The tooling already supports acceptance testing with OpenVox. Just a few gems need to be updated. newer puppet_metadata generates OpenVox jobs for git GitHub matrix, voxpupuli-acceptance pulls in a newer beaker version. By applying this, OpenVox beaker jobs are still opt-in. OpenVox has to be added as a requirement to each metadata.json. **This won't switch the unit testing from puppet to openvox** Tested at theforeman/puppet-puppet#935

sbernhard · 2025-10-15T09:30:01Z

@ekohl can we finish this?

Stricken1670 · 2025-11-04T16:58:47Z

🥳

This results from changes in theforeman/puppet-puppet#935 Signed-off-by: Eric D. Helms <[email protected]>

bastelfreak added the Enhancement label Mar 11, 2025

pr-processor bot added the Not yet reviewed label Mar 11, 2025

bastelfreak commented Mar 11, 2025

View reviewed changes

lib/facter/puppet_flavor.rb Outdated Show resolved Hide resolved

pr-processor bot removed the Not yet reviewed label Mar 11, 2025

bastelfreak force-pushed the add_openvox_support branch 3 times, most recently from 76dc42e to b43a016 Compare March 11, 2025 12:57

ekohl reviewed Mar 11, 2025

View reviewed changes

manifests/params.pp Outdated Show resolved Hide resolved

bastelfreak force-pushed the add_openvox_support branch from a7a6572 to b207a35 Compare March 11, 2025 15:35

ekohl mentioned this pull request Mar 11, 2025

Add puppet/openvox metadata voxpupuli/language-steering#1

Closed

bastelfreak mentioned this pull request May 6, 2025

[Feature request]: Agent variant fact OpenVoxProject/openfact#2

Open

ekohl requested changes Jun 3, 2025

View reviewed changes

pr-processor bot added the Waiting on contributor label Jun 3, 2025

ekohl reviewed Jun 3, 2025

View reviewed changes

manifests/server/puppetdb.pp Outdated Show resolved Hide resolved

bastelfreak force-pushed the add_openvox_support branch from de0091a to 629ed30 Compare September 30, 2025 14:00

pr-processor bot added Needs re-review and removed Waiting on contributor labels Sep 30, 2025

bastelfreak force-pushed the add_openvox_support branch from 629ed30 to 186387d Compare September 30, 2025 19:15

bastelfreak force-pushed the add_openvox_support branch from 186387d to 0d9ed0b Compare October 2, 2025 20:56

bastelfreak force-pushed the add_openvox_support branch 3 times, most recently from 3d4624e to b458215 Compare October 2, 2025 21:39

bastelfreak force-pushed the add_openvox_support branch from a004b16 to 887a26e Compare October 10, 2025 08:51

bastelfreak commented Oct 10, 2025

View reviewed changes

bastelfreak force-pushed the add_openvox_support branch 8 times, most recently from 3720cd8 to 678be11 Compare October 10, 2025 10:06

evgeni reviewed Oct 10, 2025

View reviewed changes

spec/acceptance/puppetserver_upgrade_spec.rb Outdated Show resolved Hide resolved

evgeni reviewed Oct 10, 2025

View reviewed changes

evgeni approved these changes Oct 10, 2025

View reviewed changes

bastelfreak force-pushed the add_openvox_support branch from 678be11 to 8954eb9 Compare October 10, 2025 10:57

binford2k and others added 2 commits October 10, 2025 13:17

Add OpenVox support

0925a27

This adds a fact that discovers if the Perforce or OpenVox agent is installed. If none are installed yet, we default to the Perforce package for backwards compatibility.

Enable openvox acceptance tests

771983d

bastelfreak force-pushed the add_openvox_support branch from 8954eb9 to 771983d Compare October 10, 2025 11:17

sbernhard mentioned this pull request Oct 30, 2025

Drop Puppet 7 support theforeman/foreman-installer#1043

Merged

ehelms approved these changes Nov 4, 2025

View reviewed changes

ehelms merged commit 365dcd7 into theforeman:master Nov 4, 2025
19 checks passed

ehelms added a commit to ehelms/foreman-installer that referenced this pull request Nov 5, 2025

Reset puppet package parameters if nil or empty

0f9c434

This results from changes in theforeman/puppet-puppet#935 Signed-off-by: Eric D. Helms <[email protected]>

ehelms mentioned this pull request Nov 5, 2025

Reset puppet package parameters if nil or empty theforeman/foreman-installer#1046

Merged

ehelms added a commit to ehelms/foreman-installer that referenced this pull request Nov 5, 2025

Reset puppet package parameters if nil or empty

53e8b94

This results from changes in theforeman/puppet-puppet#935 Signed-off-by: Eric D. Helms <[email protected]>

ehelms added a commit to ehelms/foreman-installer that referenced this pull request Nov 6, 2025

Reset puppet package parameters if nil or empty

cd7416d

This results from changes in theforeman/puppet-puppet#935 Signed-off-by: Eric D. Helms <[email protected]>

ehelms added a commit to ehelms/foreman-installer that referenced this pull request Nov 6, 2025

Reset puppet package parameters if nil or empty

eb9231d

This results from changes in theforeman/puppet-puppet#935 Signed-off-by: Eric D. Helms <[email protected]>

evgeni pushed a commit to theforeman/foreman-installer that referenced this pull request Nov 6, 2025

Reset puppet package parameters if nil or empty

c59d903

This results from changes in theforeman/puppet-puppet#935 Signed-off-by: Eric D. Helms <[email protected]>

Add OpenVox support #935

Add OpenVox support #935

Uh oh!

Conversation

bastelfreak commented Mar 11, 2025

Uh oh!

bastelfreak commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charlesc-profusion commented Mar 11, 2025

Uh oh!

binford2k commented Mar 11, 2025

Uh oh!

Stricken1670 commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markeganfuller commented Mar 14, 2025

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sbernhard commented Sep 9, 2025

Uh oh!

sbernhard commented Oct 2, 2025

Uh oh!

bastelfreak commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bastelfreak Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evgeni Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

evgeni commented Oct 10, 2025

Uh oh!

sbernhard commented Oct 15, 2025

Uh oh!

Uh oh!

Stricken1670 commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

bastelfreak commented Mar 11, 2025 •

edited

Loading

Stricken1670 commented Mar 14, 2025 •

edited

Loading

bastelfreak commented Oct 2, 2025 •

edited

Loading