Fixes #38914 - Use ETag-aware patch_if_match for Redfish operations #930
+136
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Redfish implementations reject PATCH requests without If-Match. This change updates boot device operations to use patch_if_match, enabling ETag-based conditional PATCH when needed.
ekohl
reviewed
Jan 14, 2026
| # Temporarily use forked redfish_client with ETag support (draft PR) | ||
| # TODO: Update to released version once PR is merged | ||
| gem 'redfish_client', git: 'https://github.com/spesnova717/redfish-client-ruby.git', branch: 'feature/redfish-etag-support' | ||
| # gem 'redfish_client', '>= 0.7.0' # Uncomment after PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some Redfish implementations reject PATCH requests without If-Match.
This change updates boot device operations to use
patch_if_match, enabling ETag-based conditional PATCH when needed.
Problem
Certain BMC implementations require the
If-Matchheaderwith ETag values for PATCH operations.
The previous implementation using
system.patchdid not include this header, causing operations to fail on some hardware.
Solution
Changed PATCH operations in
modules/bmc/redfish.rbto usepatch_if_match,which automatically includes the
If-Matchheader with the appropriate ETag value when available.