Add parse_array() - #4
Open
nomike wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a fuction
parse_array, which can parse arbitrary multidimensional float/int arrays from strings.I've also added a few test cases and an entry to the readme.
The use case of this function is to allow complex lists to be customized.
The customizer only supports one dimensional lists of up to 4 elements. But with this function, the parameter could just be a string.
One remark about the test cases:
I've commented out one test case with exceptionally large numbers. Even though it seems to produce the correct result, the assert of the test fails.
I assume this is due to some internal floating point representation within OpenSCAD or something.
It might require a bit of trouble shooting or it can simply be ignores as it's anyway quite unlikely to ever encounter such a list in a real world example.