fix: strip trailing slash from argument before path operations (close…#535
Open
fix: strip trailing slash from argument before path operations (close…#535
Conversation
…#450) A trailing slash on a symlink caused rename() to fail with ENOTDIR because the kernel dereferenced the symlink. Strip any trailing slash from the argument early, before check_pathname_state, lstat, resolve_path, and rename, so "foo/" is treated identically to "foo". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Fixes #450
andy5995
force-pushed
the
fix-450-trailing-slash
branch
from
7e2af0d to
6599694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s #450)
A trailing slash on a symlink caused rename() to fail with ENOTDIR because
the kernel dereferenced the symlink. Strip any trailing slash from the argument early, before check_pathname_state, lstat, resolve_path, and rename, so "foo/" is treated identically to "foo".
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Fixes #450