Fix W3C WebDriver API detection for IE #169
Conversation
jason0x43
left a comment
jason0x43
left a comment
There was a problem hiding this comment.
The feature check is good. The api update less so, but that's an easy enough fix (or omission). Look into doing an inline check as well (see Server.execute). Ideally we should handle more of the feature tests inline to lower startup time. (This won't work for all checks; e.g., some feature tests can't be run on certain drivers because they'll hang the browser.)
| // W3C version, the object returned by the "/session" command contains | ||
| // value.capabilities rather than the value object being the capabilities | ||
| // object and the capabilities object contains an "se:ieOptions" property. | ||
| if (capabilities['se:ieOptions']) { |
There was a problem hiding this comment.
This is good. We should also add something to Server.execute to handle this on-the-fly (without pre-emptive feature detection). There's already code along those lines in there, but it apparently isn't handling the error being returned by IE.
| "kind": 1, | ||
| "kindString": "External module", | ||
| "flags": { | ||
| "isExported": true, |
There was a problem hiding this comment.
Let's not include the api update, or do a manual search and replace of \\ with /.
2 participants
Around version 3.12 of the IE WebDriver server (IEDriverServer.exe), it switch to using the W3C API. I added code to detect that switch.
Needed in theintern/digdug#73.