Align keys in inference output with scvitools.module._constants._MODULE_KEYS #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in issue #103
When calling
model.batch_removal(), eventually scvi'sVAEmixin.get_latent_reprentationgets called, which checks the outputs of themodule.inferencecall.It checks for the presence of
MODULE_KEYS.QZ_KEY(with value "qz"), and failing that, assumes that there isMODULE_KEYS.QZM_KEY(valueqzm) andMODULE_KEYS.QZV_KEY(valueqzv) present.In the output dictionary, these keys are respectively
qz_mandqz_v, resulting in the error.It would be better to directly use the
MODULE_KEYS.{key}, but these don't seem to be exported fromscvi-tools.