Async RandomAccessReader and zips within zips #100
Conversation
…pport create a reader implementation for stored entries within a zip file, thereby supporting stored zips within zips. Add a test for the new classes based on the existing range-test. Related to thejoshwolfe#89
thejoshwolfe
left a comment
thejoshwolfe
left a comment
There was a problem hiding this comment.
thanks for the PR! unfortunately, I'm extremely picky when it comes to this codebase, and I am inclined to implement this in a different way. I'm not going to have time to do it tonight, but I will try to get to it before the holidays and the new year.
|
|
||
| exports.runTest = runTest; | ||
|
|
||
| // zipfile obtained via: |
There was a problem hiding this comment.
thanks for being conscientious enough to add tests 👍 . However, I think we can test this functionality in a much simpler way.
There was a problem hiding this comment.
Fair enough. I wanted to be certain that ranges within what is basically another range (the zip in the zip) worked properly.
… non-async createReadStream/readStreamCallback calls, but not after running an async createReadStream call. Instead, wait for that call's callback has executed readStreamCallback before unref'ing.
|
My main goal was backwards compatibility with existing code and RandomAccessReader implementations while adding support for accessing a stored zip within a zip without having to read the whole thing into a buffer or temp file. Looking forward to seeing your approach to solving the problem. |
2 participants
Add support for an asynchronous RandomAccessReader, and using that support create a reader implementation for stored entries within a zip file, thereby supporting stored zips within zips. Add a test for the new classes based on the existing range-test.
Related to #89