Always purge all but one incomplete backups #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adejanovski
requested changes
Jun 26, 2024
Contributor
adejanovski
left a comment
adejanovski
left a comment
There was a problem hiding this comment.
Sadly we're not there yet.
I've tested this and incomplete backups remain after a purge.
Before:
medusa-test-dc1-schedule-1719391860 (started: 2024-06-26 08:51:16, finished: 2024-06-26 08:51:27)
medusa-test-dc1-schedule-1719391920 (started: 2024-06-26 08:52:16, finished: 2024-06-26 08:52:26)
medusa-test-dc1-schedule-1719391980 (started: 2024-06-26 08:53:16, finished: 2024-06-26 08:53:27)
medusa-test-dc1-schedule-1719392040 (started: 2024-06-26 08:54:16, finished: 2024-06-26 08:54:26)
medusa-test-dc1-schedule-1719392100 (started: 2024-06-26 08:55:15, finished: 2024-06-26 08:55:27)
medusa-test-dc1-schedule-1719392160 (started: 2024-06-26 08:56:15, finished: 2024-06-26 08:56:26)
medusa-test-dc1-schedule-1719392220 (started: 2024-06-26 08:57:15, finished: 2024-06-26 08:57:26)
medusa-test-dc1-schedule-1719392280 (started: 2024-06-26 08:58:15, finished: 2024-06-26 08:58:27)
medusa-test-dc1-schedule-1719392340 (started: 2024-06-26 08:59:16, finished: 2024-06-26 08:59:26)
my-backup1 (started: 2024-06-26 09:00:28, finished: Incomplete [1 of 3 nodes finished])
my-backup2 (started: 2024-06-26 09:00:52, finished: Incomplete [1 of 3 nodes finished])
my-backup3 (started: 2024-06-26 09:01:16, finished: Incomplete [1 of 3 nodes finished])
After purge (with a max_backup_count of 10):
medusa-test-dc1-schedule-1719391980 (started: 2024-06-26 08:53:16, finished: 2024-06-26 08:53:27)
medusa-test-dc1-schedule-1719392040 (started: 2024-06-26 08:54:16, finished: 2024-06-26 08:54:26)
medusa-test-dc1-schedule-1719392100 (started: 2024-06-26 08:55:15, finished: 2024-06-26 08:55:27)
medusa-test-dc1-schedule-1719392160 (started: 2024-06-26 08:56:15, finished: 2024-06-26 08:56:26)
medusa-test-dc1-schedule-1719392220 (started: 2024-06-26 08:57:15, finished: 2024-06-26 08:57:26)
medusa-test-dc1-schedule-1719392280 (started: 2024-06-26 08:58:15, finished: 2024-06-26 08:58:27)
medusa-test-dc1-schedule-1719392340 (started: 2024-06-26 08:59:16, finished: 2024-06-26 08:59:26)
my-backup1 (started: 2024-06-26 09:00:28, finished: Incomplete [1 of 3 nodes finished])
my-backup2 (started: 2024-06-26 09:00:52, finished: Incomplete [1 of 3 nodes finished])
my-backup3 (started: 2024-06-26 09:01:16, finished: Incomplete [1 of 3 nodes finished])
| def backups_to_purge_by_completion(backups): | ||
| complete, incomplete = [], [] | ||
| for backup in backups: | ||
| complete.append(backup) if backup.finished is not None else incomplete.append(backup) |
Contributor
There was a problem hiding this comment.
Issue: This doesn't work the expected way I think. Here, the completeness of the backup is checked for the local node only (we're dealing with a NodeBackup, not a ClusterBackup).
Hence, any incomplete ClusterBackup would still be considered a complete backup for the purge process.
Remember that the purge is done locally for a node, it's not a global operation and has to run on each node.
rzvoncek
force-pushed
the
radovan/keep-valid-backups-2
branch
from
34340c4 to
82bca49
Compare
|
Contributor
Author
|
The 3 failures in the CI are getting fixed in #849. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607