Improve performance of LocalStorage._list_blobs #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment was marked as resolved.
This comment was marked as resolved.
alkur-gh
force-pushed
the
master
branch
3 times, most recently
from
22a0dcc to
8a414b2
Compare
Current implementation globs over the entire root directory, but needs files only with the given prefix. Globbing over the entire root directory is very slow in case of a large number of files. 'Path.resolve()' is used in an attempt to protect against directory traversal.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation globs over the entire root directory, but needs files only with the given prefix. Globbing over the entire root directory is very slow in case of a large number of files. 'Path.resolve()' is used in an attempt to protect against directory traversal.
We had about 5 million files under the root directory for backups, so it took about 30 minutes to just list backups. After this fix, the time was reduced to 1-2 minutes.
Fixes #522 for LocalStorage.