fix: restore La Roca 1.68 plugin compatibility - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Release github.com/thellmwhisperer/roca-firstmate so La Roca 1.68 no longer skips it. Strict validation currently skips this plugin because the semantic fragment omits table seats (Nerve added seats; packaged plugin.json does not declare them). Complete the semantic fragment so it matches the database, including seats, PLUS the pending VECTOR declaration. Vector surfaces are prose plus task text, as frozen: the five family content columns (working_set_versions, archive_versions, task_state_versions, operational_doc_versions, task_artifact_versions). Selectivity is embeddings-only, never ingest: do not add an ingest verb or capability. Do not install this plugin onto any live captain La Roca install. Public PR must contain no personal paths, UUIDs, or corpus counts. Ship a green non-draft PR and arm auto-merge when CI is green; do not merge red.
What Changed
seatstable andwakeups.handled_generation, then bump the plugin version and checksum.contentcolumns of all five versioned Markdown families, without adding ingest behavior.Risk Assessment
✅ Low: The change is well-bounded and conforms to the La Roca 1.68 manifest contract, including all five vector surfaces, seats coverage, and no ingest capability.
Testing
Targeted package tests passed, La Roca v1.68.0’s real strict consumer path accepted 0.4.0 with seats and exactly five embeddings-only VECTOR surfaces, and a hermetic CLI install/update reported it as data-only; the changed-line privacy scan was clean, no live La Roca installation was touched, and all transient worktree artifacts were removed.
Evidence: La Roca 1.68 consumer validation
La Roca 1.68 accepted roca-firstmate 0.4.0 without skipping it; all 11 semantic tables include seats; VECTOR exposes exactly five content columns; ingest is absent.Evidence: Hermetic plugin update
{"action":"updated","name":"roca-firstmate","risk":"data-only","version":"0.4.0"}Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
Inspectedgit diff 72cb10cd334aadeaa0f71d23f7dc4fa529842ccb..83f53ad34bdb7ca4a678e453e1146b526e12790band confirmed the clean checkout targets commit83f53ad34bdb7ca4a678e453e1146b526e12790b.go test ./schema -run 'TestPluginManifestDescribesTheShippedDatabase|TestPluginManifestDeclaresEmbeddingsOnlyVectorSurfaces|TestChecksumsCoverExactlyTheInstallPayload|TestShippedDatabaseHasNoMirroredRows' -vROCA_FIRSTMATE_UNDER_TEST="$PWD/../.." go test ./internal/provider/plugin -run '^TestRocaFirstmate168ConsumerContract$' -vagainst La Roca v1.68.0 production validation code.Installed and updated the package withroca v1.68.0using an isolated HOME; the initial expected feature-flag setup error was fixed by enablingfeatures.pluginsonly in that hermetic environment.Scanned added public lines for personal paths, UUIDs, and corpus-count markers; none were present.Removed the downloaded La Roca source, hermetic installation, configuration, and other transient worktree artifacts; finalgit status --shortwas empty.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.