Restore video RTP timestamps for RTSP streams#19
Open
joeblack2k wants to merge 1 commit intothemactep:stablefrom
Open
Restore video RTP timestamps for RTSP streams#19joeblack2k wants to merge 1 commit intothemactep:stablefrom
joeblack2k wants to merge 1 commit intothemactep:stablefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
H264NALUnittimestamp fields with defensive zero-initVideoWorkerIMPDeviceSourcewith fallback togettimeofday()only when no encoder timestamp is availableWhy
Direct RTSP from a Thingino camera on
eufy_t8400x_t31x_sc3338_syn4343was producing repeated timestamp errors in ffmpeg/Frigate:DTS discontinuityApplication provided invalid, non monotonically increasing dtsA live binary-only deployment of this patch removed those warnings completely in direct source tests:
Notes
gettimeofday()if no propagated timestamp is present, so the change is low risk for streams that do not populate encoder timestamps