package: add Pushover to the send2 toolkit - #1529
Conversation
|
Thanks for this — the implementation follows the send2ntfy/send2gotify pattern cleanly and every integration point is wired correctly (script, 1. Branch is stale — rebase needed. This is 12 commits behind 2. Verbose mode exposes the full credential pair. 3. Priority edge cases.
4. 2.5 MB attachment limit is unguarded. Pushover rejects image attachments over 2.5 MB; the script doesn't check or resize. Higher-res sensors (4K+) can produce JPEGs over that, in which case photo notifications fail via the generic error path. The WebUI note documents the limit, but there's no guard. Has this been tested against a real camera snapshot? Nits (non-blocking):
Only item 1 blocks merge; 2–4 are worth fixing or acknowledging. |
Add send2pushover, a Pushover (pushover.net) notifier that follows the same pattern as send2ntfy/send2gotify: - /usr/sbin/send2pushover with token/user config in /etc/send2.json, optional title, message template (strftime), priority -2..1 and photo attachment via multipart upload (video unsupported) - WebUI: Pushover config page (tool-send2-pushover.html), entry in the Send-to services table, service capabilities and test button - json-send2.cgi: pushover domain read/write support - motion bridges: prudynt motion script, timps-motion and raptor-motion now honor motion.send2pushover - agent-adapter persists motion.send2pushover - timps.mk installs send2pushover alongside the other send2 tools
- rebase onto current master (db8cd52); keep Paul f6311f4 motor-active guards in all three motion bridges alongside pushover service entry - clamp priority to supported range: emergency (2) requires mandatory retry/expire params we never send, so 2 maps to 1 and out-of-range values map to 0/1; help text no longer advertises emergency - guard Pushover 2.5 MB attachment limit before upload; skip with clear error instead of generic API failure - add header note documenting verbose-mode credential exposure (pre-existing toolkit-wide, both Pushover creds travel in the multipart body) Nits: explain send_video=false persistence in tool-send2-pushover.js; move pushover block after ntfy in send2.json
b4f8b57 to
c4fbb6c
Compare
Adds send2pushover, a Pushover (pushover.net) notifier following the send2ntfy/send2gotify pattern.