-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP mode dnsd fix #345
base: master
Are you sure you want to change the base?
AP mode dnsd fix #345
Conversation
'hostname -i' now returning 127.0.0.1 is somewhat not super useful for rebuliding dnsd hosts; switch to grabbing the first IP out of /etc/dhcpd-ap.conf which should be a less worse option for AP use.
maybe we should better update /etc/hosts in access point mode and let |
That would also work. Where is the proper place to pull that IP to set it though? Currently it's kind of hard coded in a couple places (which is why I selected the dnsd-ap.conf file itself). It seems like it should just be in one place. |
@gtxaspec can you look into the ap mode to remove hardcoded values please? |
which hardcoded values? The host's IP is always going to be |
That by definition means it's hardcoded to 10.64.1.1 in two places that I know of: S42wifiap and dnsd-ap.conf I can't use hostname -i to pull it when updating dnsd-ap.conf because S04hostname is setting it to 127.0.1.1 (why?), so it kind of messes up those lookups. So since it's already hardcoded in dnsd-ap.conf that's where I pulled it from. If hostname -i can return the correct IP from the start then this patch can go away. |
whitespace cleanup for patch to pull IP from dnsd-ap.conf in AP mode.
This fixes up AP mode dnsd.conf to have the correct IP for the user-specified hostname.
Currently pulling the first entry in dnsd-ap.conf, since that seems about a consistent place as any to get it.