Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP mode dnsd fix #345

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

AP mode dnsd fix #345

wants to merge 13 commits into from

Conversation

goatzillax
Copy link
Contributor

This fixes up AP mode dnsd.conf to have the correct IP for the user-specified hostname.

Currently pulling the first entry in dnsd-ap.conf, since that seems about a consistent place as any to get it.

@themactep
Copy link
Owner

maybe we should better update /etc/hosts in access point mode and let $(hostname -i) pick up the correct ip address?

@goatzillax
Copy link
Contributor Author

That would also work. Where is the proper place to pull that IP to set it though? Currently it's kind of hard coded in a couple places (which is why I selected the dnsd-ap.conf file itself). It seems like it should just be in one place.

@themactep
Copy link
Owner

@gtxaspec can you look into the ap mode to remove hardcoded values please?

@gtxaspec
Copy link
Collaborator

gtxaspec commented Dec 9, 2024

which hardcoded values? The host's IP is always going to be 100.64.1.1

@goatzillax
Copy link
Contributor Author

That by definition means it's hardcoded to 10.64.1.1 in two places that I know of: S42wifiap and dnsd-ap.conf

I can't use hostname -i to pull it when updating dnsd-ap.conf because S04hostname is setting it to 127.0.1.1 (why?), so it kind of messes up those lookups.

So since it's already hardcoded in dnsd-ap.conf that's where I pulled it from. If hostname -i can return the correct IP from the start then this patch can go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants