feat(comment): hide most of info in archived/banned comments#3757
Open
feat(comment): hide most of info in archived/banned comments#3757
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3757 +/- ##
===========================================
+ Coverage 58.21% 58.30% +0.08%
===========================================
Files 866 867 +1
Lines 17175 17216 +41
Branches 3163 3172 +9
===========================================
+ Hits 9999 10038 +39
- Misses 6495 6498 +3
+ Partials 681 680 -1 ☔ View full report in Codecov by Sentry. |
gary02
force-pushed
the
feat/hide-archived-comment-info
branch
from
e6786cf to
aee1516
Compare
robertu7
approved these changes
Jan 13, 2024
| return createdAt | ||
| } else { | ||
| // invalid date | ||
| return new Date(0) |
Contributor
There was a problem hiding this comment.
should return null instead?
Contributor
Author
There was a problem hiding this comment.
createdAt: DateTime!
can not return null here without update schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.