-
Notifications
You must be signed in to change notification settings - Fork 25
WIP: Channel branch #5204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kechicode
wants to merge
368
commits into
develop
Choose a base branch
from
feat/new-discover-with-channel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Channel branch #5204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add internationalized "Following" title to Follow page - Restructure Follow page header with new title and tabs section - Remove unnecessary Spacer component - Adjust Tabs styles to remove top margin
- Add new green color variable for notifications - Update notification icon size for mobile and desktop - Implement ringing animation for unread notifications
- Implement CHANNEL_BY_SHORT_HASH GraphQL query - Add ChannelHeader component to MainFeed - Conditionally render channel header in empty and populated feed states - Add CSS styles for channel header
- Add `excludeChannelArticles: true` parameter to newest feed query - Prevent channel-specific articles from appearing in the main feed
- Modify link processing to use current hostname - Add fallback for localhost development environment - Prevent potential cross-origin issues with announcement links
- Add responsive image sizing for mobile and desktop views - Update grid layout for ICYMI feed to be mobile-friendly - Adjust aspect ratio for article cover images on smaller screens
…ction - Modify LanguageSwitch test to use getAllByRole for more robust button selection - Ensure compatibility with potential multiple button scenarios - Maintain existing test logic for language switching functionality
- Modify test to use getAllByText for more robust button selection - Ensure compatibility with potential multiple button scenarios
…dation feeds - Add 'xxs' size option to Slides component - Implement responsive slide sizing for article and user recommendation feeds - Conditionally render slides with different sizes based on screen width - Add optional cover image display for mobile views
- Separate channel name and description into distinct elements - Add sticky positioning for channel header - Create separate CSS class for description styling - Implement responsive top positioning for different screen sizes
- Implement sticky header with dynamic top positioning - Add background color and z-index for header visibility - Ensure responsive top positioning across different screen sizes
- Reduce top margin for article feeds - Implement sticky positioning for tabs with responsive top positioning - Add background color and z-index for tabs visibility
- Improve loading condition for main feed - Add dynamic placeholder count in infinite scroll - Render placeholders dynamically based on configurable count
- Create reusable ArticleFeedPlaceholder for dynamic loading states - Support configurable placeholder count and optional spacing - Implement responsive styling for mobile views
- Rename `_Home` to `HomeView` for improved readability - Update import and component reference in Home page
- Prevent URL modification for local development - Simplify URL transformation logic - Ensure consistent link behavior across different runtime environments
- Import fragments from DropdownActions/gql instead of the component - Simplify fragment import to improve modularity
fix(GlobalNav): update logo button href to point directly to home page
Fix/update aside style
…e group indices and improve color distribution analysis
…unction to group index for clarity
…GROUPS enum for better maintainability
…ick handlers to use node.id for consistency
…dRenderer for cleaner code
…o Dropdown components for improved positioning
Feat/update cover alogrithm
…dropdown behavior on scroll
…operty to Dropdown components for improved positioning" This reverts commit 971c315.
…t for improved positioning
Fix/update dropdown menu
…m-dev Sync into channel branch from dev branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
src/common/utils/channels.ts
src/common/enums/channel.ts