-
Notifications
You must be signed in to change notification settings - Fork 294
feat: Add reactivity to toast wrapper #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@bmanth60 is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe change updates the computation of the Changes
Sequence Diagram(s)sequenceDiagram
participant Toast as Toast.svelte
participant Merge as twMerge Function
note over Toast: Dependencies update:\nalign, divClass, positions[position], $$props.class
Toast->>Merge: Call twMerge(...) with current dependencies
Merge-->>Toast: Return merged class string
note over Toast: finalDivClass is updated reactively
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
src/lib/toast/Toast.svelteOops! Something went wrong! :( ESLint: 9.22.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@eslint/js' imported from /eslint.config.js 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Code style issues were found on Readme, but my PR does not need to update it. |
Closes #
📑 Description
For my use case, the Toast component dark theme is very similar to my background. I wanted to add some styles to the border to match the icon class, however it was not reactive.
This PR adds reactivity to the wrapping div classes.
I note that this could be low priority.
Status
✅ Checks
ℹ Additional Information
Summary by CodeRabbit