Refactor alert examples to use FwbButton#377
Conversation
WalkthroughThe changes update the alert component documentation and its example by replacing native HTML Changes
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/components/alert.md(1 hunks)docs/components/alert/examples/FwbAlertExampleCustomContent.vue(1 hunks)
🧰 Additional context used
🪛 ESLint
docs/components/alert/examples/FwbAlertExampleCustomContent.vue
[error] 62-62: Extra semicolon.
(@stylistic/semi)
🪛 GitHub Check: lint (18.x)
docs/components/alert/examples/FwbAlertExampleCustomContent.vue
[failure] 62-62:
Extra semicolon
🪛 GitHub Actions: Node.js CI
docs/components/alert/examples/FwbAlertExampleCustomContent.vue
[error] 62-62: ESLint: Extra semicolon (@stylistic/semi)
🔇 Additional comments (5)
docs/components/alert/examples/FwbAlertExampleCustomContent.vue (2)
26-45: Good replacement of HTML button with FwbButton componentThe replacement of the native HTML button with the
FwbButtoncomponent is well-implemented, including proper use of the#prefixslot for the SVG icon and appropriate props for styling (color="blue",size="sm").
46-54: LGTM: Proper implementation of dismiss buttonThe dismiss button implementation maintains all the necessary attributes (
data-dismiss-target,aria-label) and event handler (@click) while properly using theFwbButtoncomponent with appropriate styling props.docs/components/alert.md (3)
230-247: Good implementation of FwbButton with proper icon placementThe replacement of the native HTML button with the
FwbButtoncomponent is well-implemented, including appropriate props (color="blue",size="sm") and proper placement of the SVG icon in the#prefixslot.
248-257: LGTM: Dismiss button correctly implementedThe dismiss button implementation properly uses the
FwbButtoncomponent with appropriate styling props while maintaining all the necessary attributes and event handlers.
263-263: Import statement correctly updatedThe import statement has been properly updated to include the
FwbButtoncomponent alongsideFwbAlert.
Replace standard HTML buttons with
FwbButtoncomponents in alert examples for improved consistency and styling.Summary by CodeRabbit