Fix for Button Light Arrangement for Dark Mode #380

[ogzcode]

#380
fix: update light button class for improved dark mode styling in FwbButton

Please check and combine @Sqrcz @cogor

Summary by CodeRabbit

• Style
  • Improved dark mode hover appearance for "light" variant buttons by updating background color on hover.

[coderabbitai]

Walkthrough

The change modifies the hover styling for the "light" variant of a button component in the codebase. Specifically, it updates the CSS classes applied on hover in dark mode by adding an explicit background color class. No changes were made to the declarations or signatures of exported or public entities.

Changes

File(s)	Change Summary
src/components/FwbButton/composables/useButtonClasses.ts	Updated the "light" button variant's hover class to include dark:hover:bg-gray-700 for improved dark mode styling.

Suggested labels

🪲 bug

Suggested reviewers

• Sqrcz

Poem

A button in the moonlit night,
Now glows with hover, dark and bright.
With styles improved for every theme,
It shines anew, or so it seems.
A rabbit hops, with CSS delight—
“Your buttons now look just right!”
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 395c52b and fdf841a.

📒 Files selected for processing (1)

• src/components/FwbButton/composables/useButtonClasses.ts (1 hunks)

🔇 Additional comments (1)

src/components/FwbButton/composables/useButtonClasses.ts (1)

27-27: Good enhancement for dark mode consistency!

Adding dark:hover:bg-gray-700 to the light button variant's hover classes is a great improvement. This change gives the light button a proper background color when hovered in dark mode, making it consistent with other button variants like "alternative" and "dark" which already use this hover background. Previously, the light button only had a border change on hover in dark mode without a background change, which could look inconsistent with the rest of the UI.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for sensational-seahorse-8635f8 ready!

Name	Link
🔨 Latest commit	fdf841a
🔍 Latest deploy log	https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/6818a0f4844f050008435357
😎 Deploy Preview	https://deploy-preview-381--sensational-seahorse-8635f8.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Sqrcz]

nice catch!

Thank you.