refactor: All deprecated code has been restructured. #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronob1010
changed the title
shamsbd71
reviewed
Nov 8, 2022
src/com_digicom/site/models/cart.php
Outdated
| { | ||
| $orderTable->amount_paid = $orderTable->amount_paid + $data['total_paid_amt']; | ||
| if((int)$data['total_paid_amt']>0){ | ||
| $orderTable->amount_paid = (int)$orderTable->amount_paid + (int)$data['total_paid_amt']; |
Member
There was a problem hiding this comment.
price value could be float number. so don't force it to be int
Author
There was a problem hiding this comment.
Oh! that's my bad. It was really unexpected. Thank you so much and let me fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shamsbd71 issue #420 has been refactored. Now Digicom is ready for [email protected]
Linked Conversation
Conversation Subject:
Message:
No additional details provided
View Conversation