fix(cursor): support wal mode without shm files via immutable fallback - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
openCursorDatabasewith fallback to immutable URI mode when read-only WAL initialization fails.-shmor-walfiles.Why
Cursor operates in SQLite WAL mode and removes
-shmand-walfiles when idle or cleanly closed. Opening a WAL-mode database withreadonly: truewhen-shmis absent causes SQLite statement preparation to fail withSQLITE_CANTOPEN(errno 14). Falling back tomode=ro&immutable=1allows reading the checkpointed store without requiring shared memory initialization.How to verify
bun test src/observe/adapters/cursorStore.test.ts bun run check bun run ./src/cli/index.ts learn --dry-runData handling
redactSecrets