Skip to content

fix: edge check permissions - #2450

Merged
golanglemonade merged 4 commits into
mainfrom
fix-edge-check-permissions
Jun 2, 2026
Merged

fix: edge check permissions#2450
golanglemonade merged 4 commits into
mainfrom
fix-edge-check-permissions

Conversation

@golanglemonade

Copy link
Copy Markdown
Member
  • fixes migration script to include conditions, adds ulid helper
  • uses helpers from entx for annotations check in fga
  • moves internal/ent/exportablegenerated/exportable_generated.go (from hooks)
  • Adds system owned and org owned annotations to help with generation
  • removes manually added ^ on exportable schema
  • regens to get new hasSystemOwned field in edge access checks
  • fixes bug with EnsureObjectInOrganization that would not check all edges if there were multiple and one one passed with scope checks
  • fixes bug with EnsureObjectInOrganization that would fail on edges that are system owned by only required view access

Depends on: theopenlane/entx#280

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
matoszz
matoszz previously approved these changes Jun 2, 2026
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@golanglemonade
golanglemonade disabled auto-merge June 2, 2026 16:08
@golanglemonade
golanglemonade enabled auto-merge (squash) June 2, 2026 16:08
@golanglemonade
golanglemonade merged commit de27903 into main Jun 2, 2026
21 of 22 checks passed
@golanglemonade
golanglemonade deleted the fix-edge-check-permissions branch June 2, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants