NDA Approval Email - #2453
Merged
Merged
Conversation
golanglemonade
previously approved these changes
Jun 4, 2026
golanglemonade
left a comment
golanglemonade
left a comment
Member
There was a problem hiding this comment.
LGTM but you have some failing tests - probably related to sending out two emails now instead of 1 and its string checking the email text
|
golanglemonade
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new NDA approval email that gets sent to owners, super admins, and admins - the construction uses a single email with multiple recipients rather than a single email per user. Easily changed if the behavior is undesirable. Since you can't link to a specific approval request (they are all in a table) the URL behind the button is static.