Skip to content

chore: bump planx-core (RAB submission performance fixes)#5862

Draft
jessicamcinchak wants to merge 7 commits into
mainfrom
jess/bump-planx-core-888bbc1
Draft

chore: bump planx-core (RAB submission performance fixes)#5862
jessicamcinchak wants to merge 7 commits into
mainfrom
jess/bump-planx-core-888bbc1

Conversation

@jessicamcinchak

@jessicamcinchak jessicamcinchak commented Dec 7, 2025

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Dec 7, 2025

Copy link
Copy Markdown

Pizza

Deployed d347a9e to https://5862.planx.pizza.

Useful links:

@DafyddLlyr DafyddLlyr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pizza -

  • I can create a Medway RAB submissions
  • I can download a Medway RAB submission (after sorting out populating flow_integrations table - still need to fix sync script for this sorry!)
  • Zip download completes in ~8 seconds ✅

Docker API logs from Pizza -

{"metric":"findSession-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"131.89ms"}
{"metric":"digitalPlanningDataPayload-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"7557.04ms"}
{"metric":"downloadS3Files-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8-count-1","duration":"212.25ms"}
{"metric":"generateHTML-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"207.00ms"}
{"metric":"generateMapAndLabelHTML-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"13.38ms"}
{"metric":"writeDisk-Final-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"53.72ms"}
{"metric":"zipTotal-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"8242.48ms"}

The digitalPlanningDataPayload step is still slower than I was expecting based on the benchmarks in planx-core, but a huge improvement (and the changes in theopensystemslab/planx-core#885 will also help!)

@jessicamcinchak

Copy link
Copy Markdown
Member Author

@DafyddLlyr thanks for testing !!

Regression tests currently failing on this branch: https://github.com/theopensystemslab/planx-new/actions/runs/20009795006

Invite to Pay isn't happy about the Session type change I think, so I'm just trying to get that sorted now. Regression tests "React" step curiously passed without issue, despite failures on main over the weekend !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants