chore: bump planx-core (RAB submission performance fixes)#5862
Draft
jessicamcinchak wants to merge 7 commits into
Draft
chore: bump planx-core (RAB submission performance fixes)#5862jessicamcinchak wants to merge 7 commits into
jessicamcinchak wants to merge 7 commits into
Conversation
PizzaDeployed d347a9e to https://5862.planx.pizza. Useful links: |
DafyddLlyr
approved these changes
Dec 7, 2025
Contributor
There was a problem hiding this comment.
Tested on Pizza -
- I can create a Medway RAB submissions
- I can download a Medway RAB submission (after sorting out populating
flow_integrationstable - still need to fix sync script for this sorry!) - Zip download completes in ~8 seconds ✅
Docker API logs from Pizza -
{"metric":"findSession-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"131.89ms"}
{"metric":"digitalPlanningDataPayload-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"7557.04ms"}
{"metric":"downloadS3Files-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8-count-1","duration":"212.25ms"}
{"metric":"generateHTML-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"207.00ms"}
{"metric":"generateMapAndLabelHTML-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"13.38ms"}
{"metric":"writeDisk-Final-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"53.72ms"}
{"metric":"zipTotal-d3e98a40-a1c9-41d9-8c61-96c077d3b8f8","duration":"8242.48ms"}The digitalPlanningDataPayload step is still slower than I was expecting based on the benchmarks in planx-core, but a huge improvement (and the changes in theopensystemslab/planx-core#885 will also help!)
Member
Author
|
@DafyddLlyr thanks for testing !! Regression tests currently failing on this branch: https://github.com/theopensystemslab/planx-new/actions/runs/20009795006 Invite to Pay isn't happy about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See theopensystemslab/planx-core#885 & theopensystemslab/planx-core#886
And lots of notes in this Slack thread https://opensystemslab.slack.com/archives/C088K9ZL8EA/p1764928037193329
Regression tests against this branch failing ❗ https://github.com/theopensystemslab/planx-new/actions/runs/20011306733