Skip to content

Lat Long NaN issue fixed - #29

Open
akashmahale wants to merge 1 commit into
theopolisme:masterfrom
akashmahale:master
Open

Lat Long NaN issue fixed#29
akashmahale wants to merge 1 commit into
theopolisme:masterfrom
akashmahale:master

Conversation

@akashmahale

Copy link
Copy Markdown

image

@huntfx

huntfx commented Mar 16, 2023

Copy link
Copy Markdown

This solves the bug but introduces another one. It's cutting off every point below 0 latitude.

image

Seems to work with !isNaN(latitude) && !isNaN(longitude) instead.

@polarfoxDev polarfoxDev mentioned this pull request Jul 16, 2023
Comment thread index.js
if ( latitude > 180 ) latitude = latitude - (2 ** 32) * SCALAR_E7;
if ( longitude > 180 ) longitude = longitude - (2 ** 32) * SCALAR_E7;

if ( type === 'json' ) latlngs.push( [ latitude, longitude ] );

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34 really fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants