macOS server support - #691
Merged
Merged
Conversation
RDIL
commented
May 2, 2026
|
|
||
| app.use(function badPathRewritingMiddleware(req, _, next) { | ||
| req.url = req.url.replaceAll("//", "/") | ||
| // rewrite every `//` to `/` that occurs before the query string |
Member
Author
There was a problem hiding this comment.
?issuer=https://appleid.apple.com, because that makes total sense
RDIL
marked this pull request as ready for review
May 2, 2026 19:43
RDIL
commented
May 2, 2026
alex73630
approved these changes
May 2, 2026
alex73630
left a comment
alex73630
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🎉
(RIP Stadia o7)
Contributor
|
Just a quick question, have we tested against Intel Macs or those are not supported by the game anyway? |
Contributor
|
Not supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Several patches to let the game log in to the server via the macOS steam version.
The steam version works, the apple version doesn't yet.
Test Plan
Log in successfully from macOS Steam version of the game with
--disable-dynamic-resources.Checklist
General
Testing