Skip to content

Add trailing slash for deleteDir #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add trailing slash for deleteDir #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/WebDAVAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ public function createDir($path, Config $config)
*/
public function deleteDir($dirname)
{
return $this->delete($dirname);
$path = rtrim($dirname, $this->pathSeparator) . $this->pathSeparator;
return $this->delete($path);
}

/**
Expand Down
6 changes: 3 additions & 3 deletions tests/WebDAVTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public function testRenameFailException()
public function testDeleteDir()
{
$mock = $this->getClient();
$mock->shouldReceive('request')->with('DELETE', 'some/dirname')->once()->andReturn(['statusCode' => 200]);
$mock->shouldReceive('request')->with('DELETE', 'some/dirname/')->once()->andReturn(['statusCode' => 200]);
$adapter = new WebDAVAdapter($mock);
$result = $adapter->deleteDir('some/dirname');
$this->assertTrue($result);
Expand All @@ -193,7 +193,7 @@ public function testDeleteDir()
public function testDeleteDirFailNotFound()
{
$mock = $this->getClient();
$mock->shouldReceive('request')->with('DELETE', 'some/dirname')->once()->andThrow('Sabre\DAV\Exception\NotFound');
$mock->shouldReceive('request')->with('DELETE', 'some/dirname/')->once()->andThrow('Sabre\DAV\Exception\NotFound');
$adapter = new WebDAVAdapter($mock);
$result = $adapter->deleteDir('some/dirname');
$this->assertFalse($result);
Expand All @@ -202,7 +202,7 @@ public function testDeleteDirFailNotFound()
public function testDeleteDirFailNot200Status()
{
$mock = $this->getClient();
$mock->shouldReceive('request')->with('DELETE', 'some/dirname')->once()->andReturn(['statusCode' => 403]);
$mock->shouldReceive('request')->with('DELETE', 'some/dirname/')->once()->andReturn(['statusCode' => 403]);
$adapter = new WebDAVAdapter($mock);
$result = $adapter->deleteDir('some/dirname');
$this->assertFalse($result);
Expand Down