fix: solve issue with checking folder existence using FTP#1838
fix: solve issue with checking folder existence using FTP#1838mhmmdtech wants to merge 1 commit intothephpleague:3.xfrom
Conversation
fix: solve issue with checking folder existence using FTP
|
I had a project that was developed with Laravel 7 and I upgraded it to Laravel 11. In this process, I needed to install this package and use it to upload the file to the download host via FTP. But I had a challenge in checking folder existence, and with changes in this commit, after each successful check of the folder path, if that folder exists, we will return to the original path and we are ready to check the new path. |
|
@SamMousa |
|
Code lgtm, i think the issue is in annotations of the provider |
|
I understand, but what confuses me is that my code works fine in your tests in PHP versions (8.0, 8.2, 8.3, and 8.4) But I only get an error in version 8.1, please guide me more clearly. Do I need to change something else to add these two lines of code, which are even written in the PHP notes? |
|
I don't have time to look into that; also I don't think it's needed. IMO we should just drop php 8.1 since it is EOL https://www.php.net/supported-versions.php I'm merely a contributor here so I don't decide these things. |
fix: solve issue with checking folder existence using FTP