add missing guzzle-exception annotations#1055
Merged
ramsey merged 1 commit intothephpleague:masterfrom Feb 26, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1055 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 193 193
===========================================
Files 20 20
Lines 521 521
===========================================
Hits 521 521
|
Contributor
|
Thank you for contributing! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances exception documentation by adding missing throws-annotations for guzzle exceptions like ConnectException, which can be thrown across the package. It builds upon the changes made in #1050.
Changes
Added throws-annotations for guzzle exceptions in method doc blocks.