fix: link against Security framework on macOS#362
Open
MrCyjaneK wants to merge 1 commit into
Open
Conversation
Owner
|
Hmm.. a bit of a hack, as the link errors are from |
Contributor
|
This should not be needed, perhaps, since 1.54 builds fine without forcing it: https://ports.macports.org/port/mrustc-rust/details (and yeah, this is not the latest version, but I have built 1.54 with the latest mrustc too). Now, I am not sure if such linking may have adverse effects, since the framework exists at least back to 10.5, I think. But it probably should be done for the crate, not generally. It could potentially mess something up, when non-default SSL implementation is used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change running
./build-1.54.0.shresulted in the following error:With this one it builds just fine