rustc-src: enable rustix use-libc feature, revert ported attributes#400
Open
LinuxUserGD wants to merge 2 commits into
Open
rustc-src: enable rustix use-libc feature, revert ported attributes#400LinuxUserGD wants to merge 2 commits into
use-libc feature, revert ported attributes#400LinuxUserGD wants to merge 2 commits into
Conversation
Contributor
|
That revert patch is pretty big and will almost certainly cause huge conflicts in the next release. Would patching away the |
Contributor
Author
The error also occurs when removing it from I'm not sure how to solve this issue in mrustc, maybe patching minicargo (https://github.com/thepowersgang/mrustc/blob/master/tools/minicargo/build.cpp) would work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workarounds for the following bugs:
This patches the rustix dependency in all cargo crates to include the
use-libcfeature.The workaround for #365 was mentioned in https://www.github.com/thepowersgang/mrustc/issues/365#issuecomment-3904762958.
The stage0 rustc fails to compile any project with the error "out of TLS keys" on musl.
This happens because the thread-local storage was bumped with the recent additions/ports of attribute parsers in Rust 1.90.0 (see termux/termux-packages#26682, rust-lang/rust#147590).
Instead of bumping the limit by changing the musl source code, I've reverted the relevant commits (e. g. "Port #[rustc_coherence_is_core] to the new attribute system") from rust's git history.
Fixes #388 (rust 1.90.0 packaging)