Skip to content

Conversation

@aaronliu0130
Copy link

and comment out pass functions that are the same as the fallback adapter and implement some more functions
and remove unneeded imports and libraries
and bump version

The metadata stuff still never gets called on my KDE desktop, but the media control buttons are working now.

Also, I think only direct dependencies should be listed in requirements, since the packages we actually rely on could drop any of these dependencies at any moment.

and comment out pass functions that are the same as the fallback adapter
and implement some more functions
and remove unneeded imports and libraries
and bump version
@ther0n
Copy link
Owner

ther0n commented May 13, 2025

Hey thanks for the PR!

So with this project the way I have it set up, requirements.txt shouldn't be modified by hand. Dependencies are managed in Pipfile, which shouldn't be modified by hand either. Rather it should be modified by pipenv following the documentation here: https://pipenv.pypa.io/en/latest/index.html

Also, I think only direct dependencies should be listed in requirements, since the packages we actually rely on could drop any of these dependencies at any moment.

The current requirements.txt was generated with pipenv lock -r > requirements.txt. The reason for this is so that every time a user installs the application with pipx install git+https://github.com/ther0n/beefweb_mpris.git they get the exact same dependencies that are known to work, regardless of updates to dependencies. At some point the code was updated to use the newer schema, but when I went to install it again it didn't work which resulted in looking into how to make this reproducible into the future. Sidenote, I noticed that I forgot to update the README.md to use pipx instead of pip, so that the dependencies are contained to only be used for beefweb_mpris and not clog up the global/user python install. All fixed now.

So in summary to get this ready to merge:

  • clone down your branch and delete requirements.txt and Pipfile.lock.
  • Run pipenv install
  • Use pipenv commands to update the dependencies in Pipfile
  • Generate a new Pipfile.lock and requirements.txt
  • Increment the version in setup.py
  • Push the changes
  • Install beefweb_mpris from scratch using pipx install <url of your branch>
  • Test and make sure everything works

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants