add choosing port#24
Conversation
| code_challenge_method: 'S256', | ||
| }); | ||
|
|
||
| console.log(`https://accounts.spotify.com/authorize?${params.toString()}`) |
There was a problem hiding this comment.
I assume you left this by accident?
| "default": 8000, | ||
| "minimum": 1024, | ||
| "maximum": 65535, | ||
| "description": "Port of the Spotify app." |
There was a problem hiding this comment.
I think this is a bit misleading. Let's clarify, for example:
"Port used for the Spotify OAuth callback."
|
Good job, @Kamix-08, thanks for the PR. I left a couple of comments, please check them out. Also, the check https://github.com/therepanic/spotilyrics/actions/runs/22495784639/job/65256827880?pr=24 is failing now. You can fix this by using the |
|
that should be better now |
|
Thanks again for the PR. You can see that I've attached some more commits that polish your work. Specifically, I added a command to change the port in VSCode itself, as well as a way to change the port in the window itself when logging in via Spotify OAuth, and I've documented it all. In the next few hours, I'll be releasing an update to the VSCode Marketplace itself. |
2 participants
added a possibility to choose a port other than
:8000might be useful when
:8000is already occupied (like in my case)