Skip to content

display title and icon#25

Merged
therepanic merged 1 commit into
therepanic:masterfrom
kamix-08:master
Mar 13, 2026
Merged

display title and icon#25
therepanic merged 1 commit into
therepanic:masterfrom
kamix-08:master

Conversation

@kamix-08

@kamix-08 kamix-08 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

add displaying the current song's title and cover on the panel

demo

@therepanic therepanic self-requested a review March 4, 2026 19:00
@therepanic

Copy link
Copy Markdown
Owner

Thanks for the PR and interest in the project!

I think your suggestion is pretty cool. I have a few suggestions before we push this change. First, how about adding the artist's name before the track title? For example, "Joji - Glimpse of Us." Second, let's make it possible to switch modes using CTRL+SHIFT+P (see b8e8c44 ‎src/extension.ts, package.json).

Additionally, if you'd like, you can also add a description of this feature to the documentation (see 4995ae0).

I'll also leave a comment below; please read it.

Comment thread src/extension.ts Outdated
@kamix-08

kamix-08 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Sounds good, I'll try to find time to add that by the weekend

@kamix-08

kamix-08 commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

alr, ready for review

@therepanic therepanic added this to the 1.0.9 milestone Mar 6, 2026
Comment thread src/extension.ts Outdated
Comment thread package.json Outdated
Comment thread src/extension.ts Outdated
Comment thread src/extension.ts Outdated
Comment thread package.json Outdated
@therepanic therepanic merged commit c082032 into therepanic:master Mar 13, 2026
5 checks passed
@therepanic

Copy link
Copy Markdown
Owner

Thanks again for the PR, @kamix-08. Merged!

BTW, please note that I've made some changes to your edits. I've also been considering, and ultimately decided to use a single format, instead of using the hide/toggle keywords, like spotilyrics.songArtists.

I need a little time to roll out the new version and upload it to the marketplace, as I want to sort out other things on the project. I'll try to get it out this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants