-
Notifications
You must be signed in to change notification settings - Fork 90
[H-01] Game Passes Audit #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[H-01] Game Passes Audit #1654
Conversation
…et mint and add tests
…e/sandbox-smart-contracts into passes-audit-m-02
Consider accumulating in a local variable instead in an extra storage variable to save gas. |
I wanted to follow something similar as in the NFTCollection contract where we store The gas cost increase is acceptable since its just storing an extra uint for each token. |
[N-09] Game Passes Audit
[H-02] Game Passes Audit
[H-01 FOLLOW UP] Game Passes Audit
[N-04 FOLLOW UP] Game Passes Audit
[N-01 FOLLOW UP] Game Passes Audit
[L-07] Game Passes Audit
[L-06] Game Passes Audit
[EXTRA-02] Game Passes Audit
…re-id [EXTRA-01] Game Passes Audit
[N-08] Game Passes Audit
[N-07] Game Passes Audit
[N-06] Game Passes Audit
[N-05] Game Passes Audit
[N-04] Game Passes Audit
[N-03] Game Passes Audit
[N-02] Game Passes Audit
[N-01] Game Passes Audit
[L-05] Game Passes Audit
[L-04] Game Passes Audit
[L-03] Game Passes Audit
[L-02] Game Passes Audit
[L-01] Game Passes Audit
[M-04] Game Passes Audit
[M-03] Game Passes Audit
[M-02] Game Passes Audit
The fix involves tracking and updating totalMinted inside the tokenConfig which is incremented before we check if the new amount does not exceed the maxSupply.