Skip to content

[M-02] Game Passes Audit #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 58 commits into from
Apr 15, 2025
Merged

[M-02] Game Passes Audit #1655

merged 58 commits into from
Apr 15, 2025

Conversation

wojciech-turek
Copy link
Member

image

Added maxPerWallet incrementing in the specified function.
Added the ability to configure a token with 0 max per wallet amount representing no limit per wallet.

@wojciech-turek wojciech-turek requested a review from a team as a code owner March 24, 2025 13:19
atkinsonholly
atkinsonholly reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@atkinsonholly atkinsonholly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should this behave if max per wallet is not configured?
Would it be better to set unlimited as max uint?

@wojciech-turek
Copy link
Member Author

A single value cannot be not configured.
The TokenConfig has isConfigured boolean which is checked every time we try to use that data.
When this boolean is true that means everything in the config is configured.

wojciech-turek and others added 28 commits April 3, 2025 09:41
@wojciech-turek
Update tests
190726b
@wojciech-turek
Update the comments
c922808
@wojciech-turek
Mark the signature verification functions internal
eec49f6
@wojciech-turek
Remove redundant check
a4d8f9f
@wojciech-turek
Merge pull request #1682 from thesandboxgame/passes-audit-n-09
2e3b907 
[N-09] Game Passes Audit
@wojciech-turek
Merge pull request #1681 from thesandboxgame/passes-audit-h-02
5dfaeac 
[H-02] Game Passes Audit
@wojciech-turek
Merge pull request #1678 from thesandboxgame/passes-audit-h-01-follow-up
2e3a581 
[H-01 FOLLOW UP] Game Passes Audit
@wojciech-turek
Merge pull request #1677 from thesandboxgame/passes-audit-n-04-follow-up
ac03964 
[N-04 FOLLOW UP] Game Passes Audit
@wojciech-turek
Merge pull request #1676 from thesandboxgame/passes-audit-n-01-follow-up
e0bc18f 
[N-01 FOLLOW UP] Game Passes Audit
@wojciech-turek
Merge pull request #1674 from thesandboxgame/passes-audit-l-07
7303c48 
[L-07] Game Passes Audit
@wojciech-turek
Merge pull request #1673 from thesandboxgame/no-caller-check
cbe7e70 
[L-06] Game Passes Audit
@wojciech-turek
Merge pull request #1672 from thesandboxgame/use-max-for-unlimited
67a4af4 
[EXTRA-02] Game Passes Audit
@wojciech-turek
Merge pull request #1671 from thesandboxgame/change-nonces-to-signatu…
6701902 
…re-id

[EXTRA-01] Game Passes Audit
@wojciech-turek
Merge pull request #1670 from thesandboxgame/passes-audit-n-08
dfa768d 
[N-08] Game Passes Audit
@wojciech-turek
Merge pull request #1669 from thesandboxgame/passes-audit-n-07
d2cd760 
[N-07] Game Passes Audit
@wojciech-turek
Merge pull request #1668 from thesandboxgame/passes-audit-n-06
7cbe142 
[N-06] Game Passes Audit
@wojciech-turek
Merge pull request #1667 from thesandboxgame/passes-audit-n-05
11fb6f8 
[N-05] Game Passes Audit
@wojciech-turek
Merge pull request #1666 from thesandboxgame/passes-audit-n-04
eec5487 
[N-04] Game Passes Audit
@wojciech-turek
Merge pull request #1665 from thesandboxgame/passes-audit-n-03
d5af5d6 
[N-03] Game Passes Audit
@wojciech-turek
Merge pull request #1664 from thesandboxgame/passes-audit-n-02
e93c9b3 
[N-02] Game Passes Audit
@wojciech-turek
Merge pull request #1663 from thesandboxgame/passes-audit-n-01
d5f392b 
[N-01] Game Passes Audit
@wojciech-turek
Merge pull request #1662 from thesandboxgame/passes-audit-l-05
2563520 
[L-05] Game Passes Audit
@wojciech-turek
Merge pull request #1661 from thesandboxgame/passes-audit-l-04
95e94ba 
[L-04] Game Passes Audit
@wojciech-turek
Merge pull request #1660 from thesandboxgame/passes-audit-l-03
179f24e 
[L-03] Game Passes Audit
@wojciech-turek
Merge pull request #1659 from thesandboxgame/passes-audit-l-02
e3e8211 
[L-02] Game Passes Audit
@wojciech-turek
Merge pull request #1658 from thesandboxgame/passes-audit-l-01
629e449 
[L-01] Game Passes Audit
@wojciech-turek
Merge pull request #1657 from thesandboxgame/passes-audit-m-04
5d34ed1 
[M-04] Game Passes Audit
@wojciech-turek
Merge pull request #1656 from thesandboxgame/passes-audit-m-03
32ba9c1 
[M-03] Game Passes Audit
@wojciech-turek wojciech-turek merged commit 235e241 into passes-audit-h-01 Apr 15, 2025
6 checks passed
@wojciech-turek wojciech-turek deleted the passes-audit-m-02 branch April 15, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atkinsonholly atkinsonholly atkinsonholly left review comments

@adjisb adjisb adjisb approved these changes

@capedcrusader21 capedcrusader21 capedcrusader21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wojciech-turek @atkinsonholly @adjisb @capedcrusader21