[M-04] Game Passes Audit #1657
Merged
[M-04] Game Passes Audit #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is better to use a global signatureId per signed message instead of a nonce per wallet. It is easier to manage on the backend side (you don't even need a sequence, just choose a big random number per signature) and also you can use it to revoke some signature if needed. |
|
Hmmm, that might be a good idea. let me try to put it in a new PR. |
adjisb
approved these changes
Mar 25, 2025
capedcrusader21
approved these changes
Mar 26, 2025
[N-09] Game Passes Audit
[H-02] Game Passes Audit
[H-01 FOLLOW UP] Game Passes Audit
[N-04 FOLLOW UP] Game Passes Audit
[N-01 FOLLOW UP] Game Passes Audit
[L-07] Game Passes Audit
[L-06] Game Passes Audit
[EXTRA-02] Game Passes Audit
…re-id [EXTRA-01] Game Passes Audit
[N-08] Game Passes Audit
[N-07] Game Passes Audit
[N-06] Game Passes Audit
[N-05] Game Passes Audit
[N-04] Game Passes Audit
[N-03] Game Passes Audit
[N-02] Game Passes Audit
[N-01] Game Passes Audit
[L-05] Game Passes Audit
[L-04] Game Passes Audit
[L-03] Game Passes Audit
[L-02] Game Passes Audit
[L-01] Game Passes Audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the issue the batch mint function now accepts a single signature.