Skip to content

[H-03] Game Passes Audit #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 27, 2025
Merged

[H-03] Game Passes Audit #1685

merged 8 commits into from
Apr 27, 2025

Conversation

wojciech-turek
Copy link
Member

image

  • Fixed the issue with inconsistent check of maxPerWallet
  • Removed unnecessary comment
  • Use per token metadata

@wojciech-turek wojciech-turek requested a review from a team as a code owner April 22, 2025 07:48
adjisb
adjisb reviewed Apr 22, 2025
View reviewed changes
packages/game-passes/contracts/GamePasses.sol
Comment on lines 1389 to 1391
if (config.maxPerWallet == 0) {
revert ExceedsMaxPerWallet(tokenId, to, amount, 0);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a special condition ? It seems that the next if kind-of cover this edge case.

@wojciech-turek wojciech-turek merged commit cab59b4 into passes-contract Apr 27, 2025
6 checks passed
@wojciech-turek wojciech-turek deleted the passes-audit-h-03 branch April 27, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adjisb adjisb adjisb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wojciech-turek @adjisb