Skip to content

Fix Custom Release URL Not Working and Compilation Failure #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YageGeng
Copy link

  1. Set function postgresql_archive::configuration::theseus::matcher::matcher as the default matcher​
  2. ​​Register the default matcher for the custom URL​

@YageGeng
Copy link
Author

YageGeng commented May 22, 2025

Hi @brianheineman ,​​
You can test this issue using the custom repo here: https://github.com/AtomInnoLab/postgresql-binaries. Feel free to provide any feedback or suggestions—I welcome all critiques and improvements!

Thanks in advance for your help!

@brianheineman
Copy link
Contributor

Hello @YageGeng, thank you for reporting the error and submitting a PR. As far as the implementation goes, I would prefer to see the matcher in a new module that is a sibling to the theseus and zonky modules under configuration, I largely try to avoid putting code into mod.rs. Also, in bundle.rs I think that should be refactored to avoid the need for a CUSTOM_REPO_URL LazyLock, and instead just pass an Option<&str> into fn register_github_repository(url: Option<&str>) -> Result<()>; if a url is passed in, register the matcher for it which should avoid the need for passing the url via CUSTOM_REPO_URL.

@YageGeng
Copy link
Author

Hi @brianheineman ,
Thank you for the feedback! I agree with your suggestions and will work on addressing them as soon as possible. I’ll push the updates ​​within the next few days​​.
I'll make sure to notify you as soon as the changes are ready for review. I appreciate your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants