added nlohmann and vitis hls headers as submodules #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I like the idea of including the nlohmann JSON and ap_fixed headers to make it easier to install. I would prefer not to include them as Git submodules, but rather have them downloaded as part of the I'm not convinced about including the other headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds nhlomann and Vitis_HLS 2024.2 headers as submodules, together with some dependencies (gmp.h and mpfr.h).
The reason I made this PR is to be able to run at least the c++ backend on most of the systems without external requirements (e.g. vocms machines do not have vitis headers or lack dependencies like gmp-devel and mpfr-devel).
The user can still use another version of the vitis headers just setting the XILINX_AP_INCLUDE env var before running conifer