Fix: Skip emphasis parsing when inside link#29
Open
Aaaaash wants to merge 2 commits intothetarnav:mainfrom
Open
Fix: Skip emphasis parsing when inside link#29Aaaaash wants to merge 2 commits intothetarnav:mainfrom
Aaaaash wants to merge 2 commits intothetarnav:mainfrom
Conversation
Owner
|
text_with_underline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering we have a link with an underscore like this:
[read_md.md](https://github.com/thetarnav/streaming-markdown)We might mistakenly parse the
_in the link as an underscore mark, resulting in incorrect insertion of<em>tags in the link.We would end up with a link formatted like this:
readmd.md](https://github.com/thetarnav/streaming-markdown)Its DOM structure would resemble:
<a>read<em>md.md](https://github.com/thetarnav/streaming-markdown))</em></a>This Pull Request fixes the issue by skipping underscore parsing when encountering _ while the current token is a link.