Start adding a warning for using firefox over chrome. #182
Draft
varoonp123 wants to merge 1 commit into
Draft
Conversation
…ourage firefox because wasm and audio seem to work better on chrome and are pretty bad right now in firefox
Collaborator
|
I sent you updated files on discord, since I can't modify your fork :) |
Contributor
Author
|
If you can, make a PR from a branch on your fork :) |
Collaborator
|
varoonp123#2 edit: Updated image for reference: edit 2: |
Contributor
Author
|
@LordDeatHunter Looks great! Much better than what my backend brain could do on my own.
I meant make a PR from your fork into the main repo. # HTTPS is fine because you dont need to push directly to the main repo. HTTPS let you read/clone but
# DOES NOT let you push to their repo
git clone https://github.com/thetawavegame/thetawave.git && cd thetawave
git remote add vp https://github.com/varoonp123/thetawave.git
git remote add cds https://github.com/cdsupina/thetawave.git
# THIS MUST BE SSH/git so you can push to your fork
git remote add dh git@github.com:LordDeatHunter/thetawave.git
# Pulls in recent branches/commits into the local git db whenever you want them
# but doesnt make any changes to your local repo. I fetch right before I want to branch
git fetch vp
git fetch dh
git fetch cds
git fetch origin
# Branch off of me with a new branch name. I use the `-b` a ton
git checkout -b ui/chromeWarningAssist remotes/vp/ui/chromeWarning
echo "Do the things and commit"
# Push to your fork. Then you can PR into the thetawavegame/thetawave repo.
# You can also PR from your fork into ANY fork of the main repo
git push dh ui/chromeWarningAssist
|
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We want to discourage firefox because wasm and audio seem to work better on chrome and are pretty bad right now in firefox.
@LordDeatHunter can you provide some input on the html+css? I probably should have run prettier in a separate commit. I am not so comfortable with front end stuff.
