-
Notifications
You must be signed in to change notification settings - Fork 33
Adding ensemble support in forward runs and inversion #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Brazovskis
wants to merge
9
commits into
main
Choose a base branch
from
ensemble_runs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0f951b7
Update exporter.py to work with ensembles
Brazovskis 5701ed7
Update inversion_tools.py to work with ensembles/EnsembleReducedFunct…
Brazovskis 9f6fec4
Update headland_inversion example to work with ensemble runs
Brazovskis 2bf6049
- restoring docstrings
Brazovskis b37b79f
Explicitly importing numpy as np
Brazovskis 4289aee
Simplifying comm flags and adding clarifying notes
Brazovskis 00b8add
replacing redundant is_station_export_root function with no_exports p…
Brazovskis 0b9f81c
Consistent treatment of J across ensemble and non-ensemble runs
Brazovskis 026cbd9
Restoring original behaviour of consistency_test() and taylor_test().…
Brazovskis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so this indicates forward_run.py is currently broken? So it seems previously it relied on thetis or firedrake leaking
npinto its namespace, and now you're relying on thetis leakingnumpyinstead. Neither is good. Should explicitly "import numpy" on top, but I prefer if you "import numpy as np" and revert these changes (avoiding unnecessary changes)