Skip to content

Comments

added usage of removeFile to example#29

Open
yfxie wants to merge 2 commits intothetutlage:developfrom
yfxie:yfxie-patch-updated-readme
Open

added usage of removeFile to example#29
yfxie wants to merge 2 commits intothetutlage:developfrom
yfxie:yfxie-patch-updated-readme

Conversation

@yfxie
Copy link

@yfxie yfxie commented Jun 6, 2017

related issue: #28

@greggilbert
Copy link

Couple of recommendations on this:

  1. Squash the commits (git rebase) - it's cleaner
  2. Something like this to also remove the file from vue-clip's files prop:
    removeFile(file) {
      this.$refs.vc.removeFile(file);
      var index = this.$refs.vc.files.indexOf(file);
      this.$refs.vc.files.splice(index, 1);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants