updater.go: replace os.WriteFile with file.Write()

[udf2457]

Ref #667

I also added an explicit file.Close() on the error conditions here because otherwise defer file.Close() would be called after the file.Remove(), IIRC Windows errors if you attempt to remove an open file.

[kommendorkapten]

This looks good, but I'm thinking about the defer file.Close() on line 599, we can remove that too right?
As there are no paths now when there is no file.Close(). It's closed explicitly on line 624 before os.Rename().

[udf2457]

This looks good, but I'm thinking about the defer file.Close() on line 599, we can remove that too right? As there are no paths now when there is no file.Close(). It's closed explicitly on line 624 before os.Rename().

I briefly considered it but ended up focusing my PR on the subject at hand and didn't touch anything surrounding it. I guess you can edit the commit ?

[kommendorkapten]

Thank you!

[kommendorkapten]

@rdimitrov would you take an an extra look?

[rdimitrov]

Looks good 🚀 I see we can also remove some of the err variables and put the statement in the if condition directly but that's just cosmetics and can be a separate PR.