Prepare 2.2.0 release #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release contains no new tests and test results are not expected to change, except in one case: If `test_root_rotation` or `test_non_root_rotations` are marked as "Expected To Fail" because of the non-default keytype, this expectation can now be removed: these tests now use the default keytype (ecdsa). * local testing: "make dev" now checks for faketime binary to enable failing early (#240) * Failure output was improved (#239) * Tests now use default keytype whenever possible: In `practice test_non_root_rotations()` and `test_root_rotation()` switched from ed25519 to the default ecdsa key (#238) * Expected failures are now documented better (#233) Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Collaborator
|
I can't really approve anything, but you do want to me to run these tests locally against the java tuf client or anything? |
Member
Author
We can get you added to the team if you'd like to... I wouldn't mind having another reviewer.
🤷 either way works, I'm ok releasing as is too: If you notice problems afterwards we can do another point release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release contains no new tests and test results are not expected to change, except in one case: If
test_root_rotationortest_non_root_rotationsare marked as "Expected To Fail" because of the non-default keytype, this expectation can now be removed: these tests now use the default keytype (ecdsa).practice test_non_root_rotations()andtest_root_rotation()switched from ed25519 to the default ecdsa key (tests: Avoid using non-default keytypes when possible #238)