Alterations after database naming changes #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
reviewed
Apr 18, 2025
| RanksSingle rs | ||
| inner join Events e on rs.eventId = e.id | ||
| ranks_single rs | ||
| inner join Events e on rs.event_id = e.id |
There was a problem hiding this comment.
Suggested change
| inner join Events e on rs.event_id = e.id | |
| inner join events e on rs.event_id = e.id |
| @@ -28,14 +28,14 @@ queries: | |||
| c.cellName | |||
| from Results results | |||
There was a problem hiding this comment.
Suggested change
| from Results results | |
| from results |
| and single_records.personId = results.personId | ||
| and single_records.eventId = results.eventId | ||
| and single_records.person_id = results.personId | ||
| and single_records.event_id = results.eventId | ||
| and regionalSingleRecord = 'WR' |
There was a problem hiding this comment.
Suggested change
| and regionalSingleRecord = 'WR' | |
| and regional_single_record = 'WR' |
| and single_records.personId = results.personId | ||
| and single_records.eventId = results.eventId | ||
| and single_records.person_id = results.personId | ||
| and single_records.event_id = results.eventId | ||
| and regionalSingleRecord = 'WR' | ||
| inner join Competitions c on results.competitionId = c.id |
There was a problem hiding this comment.
Suggested change
| inner join Competitions c on results.competitionId = c.id | |
| inner join competitions c on results.competition_id = c.id |
| @@ -49,14 +49,14 @@ queries: | |||
| c.cellName | |||
| from Results results | |||
There was a problem hiding this comment.
Suggested change
| from Results results | |
| from results |
| personId = p.wca_id | ||
| and eventId = '555') r5 | ||
| person_id = p.wca_id | ||
| and event_id = '555') r5 | ||
| from | ||
| Persons p) r |
There was a problem hiding this comment.
Suggested change
| Persons p) r | |
| persons p) r |
| @@ -137,30 +137,30 @@ queries: | |||
| p.countryId, | |||
There was a problem hiding this comment.
Suggested change
| p.countryId, | |
| p.country_id, |
| personId = p.wca_id | ||
| and eventId = '555' | ||
| person_id = p.wca_id | ||
| and event_id = '555' | ||
| ) r5 | ||
| from | ||
| Persons p |
There was a problem hiding this comment.
Suggested change
| Persons p | |
| persons p |
| @@ -189,28 +189,28 @@ queries: | |||
| p.countryId, | |||
There was a problem hiding this comment.
Suggested change
| p.countryId, | |
| p.country_id, |
| personId = p.wca_id | ||
| and eventId = '555') r5 | ||
| person_id = p.wca_id | ||
| and event_id = '555') r5 | ||
| from | ||
| Persons p) r |
There was a problem hiding this comment.
Suggested change
| Persons p) r | |
| persons p) r |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed after thewca/worldcubeassociation.org#11217