Skip download-binaries if set SHERPA_LIB_PATH env#121
Open
BenLocal wants to merge 1 commit into
Open
Conversation
…PA_LIB_PATH before downloading. This change ensures that libraries are only fetched if the environment variable is not set, improving efficiency and preventing unnecessary downloads. Additionally, fallback handling for manual builds is maintained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor binary download logic in build.rs to check for existing SHERPA_LIB_PATH before downloading. This change ensures that libraries are only fetched if the environment variable is not set, improving efficiency and preventing unnecessary downloads. Additionally, fallback handling for manual builds is maintained.