Tonnam/feat(v2)/expaned course card dialog #737
Conversation
|
leomotors
left a comment
leomotors
left a comment
There was a problem hiding this comment.
I prefer Runes Mode for new code. If not conflict with bits-ui, please change to Runes Mode.
leomotors
left a comment
leomotors
left a comment
There was a problem hiding this comment.
expanded course card looks good for me
| <script lang="ts"> | ||
| import { cn } from '../../../../../utils' | ||
| import { Chip } from '../chip' | ||
| import { chipVariants, type Status } from './index.js' | ||
|
|
||
| let className: string | undefined | null = undefined | ||
| export let status: Status | ||
| export let closable: boolean = false | ||
| export let onClose: () => void = () => {} | ||
| export { className as class } | ||
| </script> | ||
|
|
||
| <Chip class={cn(chipVariants({ status, className }))} {closable} {onClose}> | ||
| {#if status == 'close'} | ||
| ปิด | ||
| {:else} | ||
| <slot /> | ||
| {/if} | ||
| </Chip> |
There was a problem hiding this comment.
I think this component should accept registered and max seat instead of slot
There was a problem hiding this comment.
status can be removed as it can be inferred from closed, regis, max
| import { SeatChip } from './index.js' | ||
|
|
||
| const { Story } = defineMeta<typeof SeatChip>({ | ||
| title: 'Atom/SeatChip', |
There was a problem hiding this comment.
Add space in Title
| title: 'Atom/SeatChip', | |
| title: 'Atom/Seat Chip', |
Why did you create this PR
What did you do
SeatChipcomponent and integrated it into expanded course card.ExpandedCourseCardDialogfor course detail.SeatChipandExpandedCourseCardDialog.ExpandedCourseCardDialogand moved it toMoleculecomponents.**