Allow using external Postgres and existing Secrets#111
Open
adrianAzoitei wants to merge 2 commits into
Open
Conversation
- allow disabling postgresql-ha - add keys and templates for rendering credentials and connection details for external PostgreSQL - reuse existing secret approach for Cassandra as used in subchart
adrianAzoitei
commented
Dec 8, 2023
| - name: postgresql-ha | ||
| version: 8.5.2 | ||
| repository: https://charts.bitnami.com/bitnami | ||
| repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami |
Author
There was a problem hiding this comment.
These versions are no longer available on https://charts.bitnami.com/bitnami.
Author
|
I committed |
Author
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was this needed
Support for an external PostgreSQL instance is implicit, but confusing to configure. Users still have to deploy the
postgresql-hasubchart and just use aserviceNamepointing to an external PostgreSQL.Specifying credentials is done via
values.yamlor--setat the command line, which could be insecure, depending on who else has access to the server. Using existing Secrets is a pretty common pattern for this.What was implemented
How it was tested
Ran
helm templatewith the following overriding values: