Skip to content

Added support for proprietary devices#1878

Merged
samson0v merged 6 commits intothingsboard:masterfrom
apachler:feature/bacnet-proprietary-device-support
Nov 25, 2025
Merged

Added support for proprietary devices#1878
samson0v merged 6 commits intothingsboard:masterfrom
apachler:feature/bacnet-proprietary-device-support

Conversation

@apachler
Copy link
Contributor

This feature makes it possible to inject proprietary device information the way BACpypes3 handels it.

To inject devices it is needed to import a custom class, atm this is only possible for advanced users since it is needed to implement a custom AsyncBACnetConnector class.

This PR makes sure the actual BACnet connector implementation is able to handle it.

@apachler
Copy link
Contributor Author

apachler commented Jul 11, 2025

I am working on a clean way to inject proprietary devices classes without the need of defining custom AsyncBACnetConnect.
Since i am not sure how long this will take, it would be nice to have that PR merged so everyone can use the more advanced way.

@apachler
Copy link
Contributor Author

Please do not merge this PR for now ...

@apachler apachler marked this pull request as draft July 15, 2025 10:10
@github-actions github-actions bot added the core label Jul 28, 2025
@apachler apachler marked this pull request as ready for review July 28, 2025 09:04
@apachler
Copy link
Contributor Author

Feature done with dynamic loading of custom device extension.

In folder extensions/bacnet/proprietary there is a sample file how custom objects have to be defined. All files in this directory are imported dynamically on connector start.

@apachler
Copy link
Contributor Author

@imbeacon any comments?

@samson0v
Copy link
Contributor

@apachler, thanks for the PR. I will review it soon.

@samson0v samson0v added this to the 3.7.9 milestone Sep 24, 2025
@samson0v samson0v removed the core label Oct 28, 2025
@samson0v samson0v modified the milestones: 3.7.9, 3.8.0 Oct 29, 2025
@samson0v
Copy link
Contributor

@apachler, also, please, revert changes for the uplink converter, as it was fixed.
We are planning a release tomorrow. Could you resolve the points above, so your feature will be included?

@github-actions github-actions bot added the core label Nov 25, 2025
@apachler
Copy link
Contributor Author

@apachler, also, please, revert changes for the uplink converter, as it was fixed. We are planning a release tomorrow. Could you resolve the points above, so your feature will be included?

done, hopefully i did it to your liking ;)

@apachler apachler requested a review from samson0v November 25, 2025 11:53
@samson0v
Copy link
Contributor

@apachler, well done! Thanks for your contribution!
I will merge your PR today.

@samson0v samson0v removed the core label Nov 25, 2025
@samson0v samson0v changed the title Added support for proprietary devices in BACnet connector Added support for proprietary devices Nov 25, 2025
@samson0v samson0v merged commit 197447d into thingsboard:master Nov 25, 2025
4 checks passed
@apachler apachler deleted the feature/bacnet-proprietary-device-support branch December 1, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants